Ecosyste.ms: Advisories

An open API service providing security vulnerability metadata for many open source software ecosystems.

Security Advisories: GSA_kwCzR0hTQS01ODI0LWNtM3gtM2MzOM4AA1LT

Vyper has incorrectly allocated named re-entrancy locks

Impact

In versions 0.2.15, 0.2.16 and 0.3.0, named re-entrancy locks are allocated incorrectly. Each function using a named re-entrancy lock gets a unique lock regardless of the key, allowing cross-function re-entrancy in contracts compiled with the susceptible versions. A specific set of conditions is required to result in misbehavior of affected contracts, specifically:

A .vy contract compiled with either of the following vyper versions: 0.2.15, 0.2.16, 0.3.0
A primary function that utilizes the @nonreentrant decorator with a specific key and does not strictly follow the check-effects-interaction pattern (i.e. contains an external call to an untrusted party before storage updates)
A secondary function that utilizes the same key and would be affected by the improper state caused by the primary function

Patches

https://github.com/vyperlang/vyper/pull/2439, https://github.com/vyperlang/vyper/pull/2514

Workarounds

Upgrade to 0.3.1 or higher

References

Technical post-mortem report: https://hackmd.io/@vyperlang/HJUgNMhs2

Permalink: https://github.com/advisories/GHSA-5824-cm3x-3c38
JSON: https://advisories.ecosyste.ms/api/v1/advisories/GSA_kwCzR0hTQS01ODI0LWNtM3gtM2MzOM4AA1LT
Source: GitHub Advisory Database
Origin: Unspecified
Severity: Critical
Classification: General
Published: over 1 year ago
Updated: 3 months ago

CVSS Score: 8.7
CVSS vector: CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:C/C:N/I:H/A:H

EPSS Percentage: 0.00125
EPSS Percentile: 0.47573

Identifiers: GHSA-5824-cm3x-3c38, CVE-2023-39363
References:

Repository: https://github.com/vyperlang/vyper
Blast Radius: 20.6

Affected Packages

pypi:vyper

Dependent packages: 5
Dependent repositories: 236
Downloads: 90,482 last month
Affected Version Ranges: >= 0.2.15, < 0.3.1
Fixed in: 0.3.1
All affected versions: 0.2.15, 0.2.16, 0.3.0
All unaffected versions: 0.2.1, 0.2.2, 0.2.3, 0.2.4, 0.2.5, 0.2.6, 0.2.7, 0.2.8, 0.2.9, 0.2.10, 0.2.11, 0.2.12, 0.2.13, 0.2.14, 0.3.1, 0.3.2, 0.3.3, 0.3.4, 0.3.5, 0.3.6, 0.3.7, 0.3.8, 0.3.9, 0.3.10, 0.4.0