Ecosyste.ms: Advisories

Security Advisories: GSA_kwCzR0hTQS01Y3JqLWM3MngtbTdncc0XAg

Null pointer exception when `Exit` node is not preceded by `Enter` op

Impact

The process of building the control flow graph for a TensorFlow model is vulnerable to a null pointer exception when nodes that should be paired are not:

import tensorflow as tf
  
@tf.function
def func():
  return tf.raw_ops.Exit(data=[False,False])
    
func()

This occurs because the code assumes that the first node in the pairing (e.g., an Enter node) always exists when encountering the second node (e.g., an Exit node):

  ...
} else if (IsExit(curr_node)) {
  // Exit to the parent frame.
  parent = parent_nodes[curr_id];         
  frame_name = cf_info->frame_names[parent->id()];
  ...                

When this is not the case, parent is nullptr so dereferencing it causes a crash.

Patches

We have patched the issue in GitHub commit 05cbebd3c6bb8f517a158b0155debb8df79017ff.

The fix will be included in TensorFlow 2.7.0. We will also cherrypick this commit on TensorFlow 2.6.1, TensorFlow 2.5.2, and TensorFlow 2.4.4, as these are also affected and still in supported range.

For more information

Please consult our security guide for more information regarding the security model and how to contact us with issues and questions.

Attribution

This vulnerability has been reported by members of the Aivul Team from Qihoo 360.

Permalink: https://github.com/advisories/GHSA-5crj-c72x-m7gq
JSON: https://advisories.ecosyste.ms/api/v1/advisories/GSA_kwCzR0hTQS01Y3JqLWM3MngtbTdncc0XAg
Source: GitHub Advisory Database
Origin: Unspecified
Severity: Moderate
Classification: General
Published: over 2 years ago
Updated: about 1 year ago

CVSS Score: 5.5
CVSS vector: CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:N/I:N/A:H

Identifiers: GHSA-5crj-c72x-m7gq, CVE-2021-41217
References:

• https://github.com/tensorflow/tensorflow/security/advisories/GHSA-5crj-c72x-m7gq
• https://nvd.nist.gov/vuln/detail/CVE-2021-41217
• https://github.com/tensorflow/tensorflow/commit/05cbebd3c6bb8f517a158b0155debb8df79017ff
• https://github.com/advisories/GHSA-5crj-c72x-m7gq

Repository: https://github.com/tensorflow/tensorflow
Blast Radius: 26.8

Affected Packages