Ecosyste.ms: Advisories

Security Advisories: GSA_kwCzR0hTQS02MjZxLXY5ajQtbWNwNM4AAxYW

OpenZeppelin Contracts contains Improper Verification of Cryptographic Signature

Cause

is_valid_eth_signature is missing a call to finalize_keccak after calling verify_eth_signature.

Impact

As a result, any contract using is_valid_eth_signature from the account library (such as the EthAccount preset) is vulnerable to a malicious sequencer. Specifically, the malicious sequencer would be able to bypass signature validation to impersonate an instance of these accounts.

Risk

In order to exploit this vulnerability, it is required to control a sequencer or prover since they're the ones executing the hints, being able to inject incorrect keccak results.

Today StarkWare is the only party running both a prover or a sequencer, greatly reducing the risk of exploit.

Patches

The issue has been patched in 0.6.1.

For more information

If you have any questions or comments about this advisory:

• Open an issue in the Contracts for Cairo repository
• Email us at [email protected]

Permalink: https://github.com/advisories/GHSA-626q-v9j4-mcp4
JSON: https://advisories.ecosyste.ms/api/v1/advisories/GSA_kwCzR0hTQS02MjZxLXY5ajQtbWNwNM4AAxYW
Source: GitHub Advisory Database
Origin: Unspecified
Severity: Moderate
Classification: General
Published: almost 2 years ago
Updated: about 2 months ago

CVSS Score: 5.3
CVSS vector: CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:H/I:N/A:N

Identifiers: GHSA-626q-v9j4-mcp4, CVE-2023-23940
References:

• https://github.com/OpenZeppelin/cairo-contracts/security/advisories/GHSA-626q-v9j4-mcp4
• https://nvd.nist.gov/vuln/detail/CVE-2023-23940
• https://github.com/OpenZeppelin/cairo-contracts/pull/542/commits/6d4cb750478fca2fd916f73297632f899aca9299
• https://github.com/pypa/advisory-database/tree/main/vulns/openzeppelin-cairo-contracts/PYSEC-2023-39.yaml
• https://github.com/advisories/GHSA-626q-v9j4-mcp4

Repository: https://github.com/OpenZeppelin/cairo-contracts
Blast Radius: 8.3

Affected Packages