Ecosyste.ms: Advisories

Security Advisories: GSA_kwCzR0hTQS03dnJtLTNqYzgtNXd3bc04Jg

Incorrect Comparison in Vyper

Impact

bytestrings can have dirty bytes in them, resulting in the word-for-word comparison to give incorrect results, e.g.

b1: Bytes[32] = b"abcdef"
b1 = slice(b1, 0, 1)
b2: Bytes[32] = b"abcdef"
t: bool = b1 == b2  # incorrectly evaluates to True

even without dirty nonzero bytes, because there is no comparison of the length, two bytestrings can compare to equal if one ends with "\x00".

b1: Bytes[32] = b"abc\0"
b2: Bytes[32] = b"abc"
t: bool = b1 == b2  # incorrectly evaluates to True

Patches

fixed in https://github.com/vyperlang/vyper/commit/2c73f8352635c0a433423a5b94740de1a118e508

Permalink: https://github.com/advisories/GHSA-7vrm-3jc8-5wwm
JSON: https://advisories.ecosyste.ms/api/v1/advisories/GSA_kwCzR0hTQS03dnJtLTNqYzgtNXd3bc04Jg
Source: GitHub Advisory Database
Origin: Unspecified
Severity: High
Classification: General
Published: about 2 years ago
Updated: over 1 year ago

CVSS Score: 7.5
CVSS vector: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:H/A:N

Identifiers: GHSA-7vrm-3jc8-5wwm
References:

• https://github.com/vyperlang/vyper/security/advisories/GHSA-7vrm-3jc8-5wwm
• https://github.com/vyperlang/vyper/commit/2c73f8352635c0a433423a5b94740de1a118e508
• https://github.com/pypa/advisory-database/tree/main/vulns/vyper/PYSEC-2022-196.yaml
• https://github.com/advisories/GHSA-7vrm-3jc8-5wwm

Repository: https://github.com/vyperlang/vyper
Blast Radius: 17.8

Affected Packages