Ecosyste.ms: Advisories

Security Advisories: GSA_kwCzR0hTQS03dnc3LXF4MzgtMzd2cs4AA8Vz

Propel2 SQL injection possible with limit() on MySQL

The limit() query method is susceptible to catastrophic SQL injection with MySQL.

For example, given a model User for a table users:

UserQuery::create()->limit('1;DROP TABLE users')->find();

This will drop the users table!

The cause appears to be a lack of integer casting of the limit input in either Propel\Runtime\ActiveQuery\Criteria::setLimit() or in Propel\Runtime\Adapter\Pdo\MysqlAdapter::applyLimit(). The code comments there seem to imply that casting was avoided due to overflow issues with 32-bit integers.

This is surprising behavior since one of the primary purposes of an ORM is to prevent basic SQL injection.

This affects all versions of Propel: 1.x, 2.x, and 3.

Permalink: https://github.com/advisories/GHSA-7vw7-qx38-37vr
JSON: https://advisories.ecosyste.ms/api/v1/advisories/GSA_kwCzR0hTQS03dnc3LXF4MzgtMzd2cs4AA8Vz
Source: GitHub Advisory Database
Origin: Unspecified
Severity: Critical
Classification: General
Published: 6 months ago
Updated: 6 months ago

CVSS Score: 9.8
CVSS vector: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H

Identifiers: GHSA-7vw7-qx38-37vr
References:

• https://github.com/propelorm/Propel2/issues/1463
• https://github.com/propelorm/Propel2/pull/1464
• https://github.com/propelorm/Propel2/commit/cd23d7384a15cfe203e23b3a835c8ab1d81d9246
• https://github.com/FriendsOfPHP/security-advisories/blob/master/propel/propel/2018-02-14.yaml
• https://github.com/advisories/GHSA-7vw7-qx38-37vr

Repository: https://github.com/propelorm/Propel2
Blast Radius: 27.1

Affected Packages