Ecosyste.ms: Advisories

Security Advisories: GSA_kwCzR0hTQS04bWo3LXd4bWMtZjQyNM4AArsu

Use after free in Neon external buffers

Neon provides functionality for creating JavaScript ArrayBuffer (and the Buffer subtype) instances backed by bytes allocated outside of V8/Node. The JsArrayBuffer::external and JsBuffer::external did not require T: 'static prior to Neon 0.10.1. This allowed creating an externally backed buffer from types that may be freed while they are still referenced by a JavaScript ArrayBuffer.

The following example demonstrates use after free. It compiles on versions <0.10.1 and fails to compile afterward.

pub fn soundness_hole(mut cx: FunctionContext) -> JsResult<JsArrayBuffer> {
    let mut data = vec![0u8, 1, 2, 3];
    
    // Creating an external from `&mut [u8]` instead of `Vec<u8>` since there is a blanket impl
    // of `AsMut<T> for &mut T`
    let buf = JsArrayBuffer::external(&mut cx, data.as_mut_slice());

    // `buf` is still holding a reference to `data`!
    drop(data);

    Ok(buf)
}

Permalink: https://github.com/advisories/GHSA-8mj7-wxmc-f424
JSON: https://advisories.ecosyste.ms/api/v1/advisories/GSA_kwCzR0hTQS04bWo3LXd4bWMtZjQyNM4AArsu
Source: GitHub Advisory Database
Origin: Unspecified
Severity: High
Classification: General
Published: almost 2 years ago
Updated: 11 months ago

Identifiers: GHSA-8mj7-wxmc-f424
References:

• https://github.com/neon-bindings/neon/issues/896
• https://rustsec.org/advisories/RUSTSEC-2022-0028.html
• https://github.com/advisories/GHSA-8mj7-wxmc-f424

Repository: https://github.com/neon-bindings/neon
Blast Radius: 0.0

Affected Packages