Ecosyste.ms: Advisories

Security Advisories: GSA_kwCzR0hTQS0zcDM3LTM2MzYtcTh3ds4AAzUH

Vyper vulnerable to OOB DynArray access when array is on both LHS and RHS of an assignment

Impact

during codegen, the length word of a dynarray is written before the data, which can result in OOB array access in the case where the dynarray is on both the lhs and rhs of an assignment. here is a minimal example producing the issue:

a:DynArray[uint256,3]
@external
def test() -> DynArray[uint256,3]:
    self.a = [1,2,3]
    self.a = empty(DynArray[uint256,3])
    self.a = [self.a[0],self.a[1],self.a[2]]
    return self.a # return [1,2,3]

and here is an example demonstrating the issue can cause data corruption across call frames:

@external
def test() -> DynArray[uint256,3]:
    self.a()
    return self.b() # return [1,2,3]

@internal
def a():
    a: uint256 = 0    
    b: uint256 = 1    
    c: uint256 = 2    
    d: uint256 = 3

@internal
def b() -> DynArray[uint256,3]:
    a: DynArray[uint256,3] = empty(DynArray[uint256,3])
    a = [a[0],a[1],a[2]]
    return a

examples involving append and pop:

@internal
def foo():
    c: DynArray[uint256, 1] = []
    c.append(c[0])

@internal
def foo():
    c: DynArray[uint256, 1] = [1]
    c[0] = c.pop()

the expected behavior in all of the above cases is to revert due to oob array access.

Patches

patched in 4f8289a81206f767df1900ac48f485d90fc87edb

Workarounds

Is there a way for users to fix or remediate the vulnerability without upgrading?

References

Are there any links users can visit to find out more?

Permalink: https://github.com/advisories/GHSA-3p37-3636-q8wv
JSON: https://advisories.ecosyste.ms/api/v1/advisories/GSA_kwCzR0hTQS0zcDM3LTM2MzYtcTh3ds4AAzUH
Source: GitHub Advisory Database
Origin: Unspecified
Severity: High
Classification: General
Published: over 1 year ago
Updated: about 2 months ago

CVSS Score: 7.5
CVSS vector: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:H/A:N

EPSS Percentage: 0.00166
EPSS Percentile: 0.53649

Identifiers: GHSA-3p37-3636-q8wv, CVE-2023-31146
References:

• https://github.com/vyperlang/vyper/security/advisories/GHSA-3p37-3636-q8wv
• https://nvd.nist.gov/vuln/detail/CVE-2023-31146
• https://github.com/vyperlang/vyper/commit/4f8289a81206f767df1900ac48f485d90fc87edb
• https://github.com/pypa/advisory-database/tree/main/vulns/vyper/PYSEC-2023-77.yaml
• https://github.com/advisories/GHSA-3p37-3636-q8wv

Repository: https://github.com/vyperlang/vyper
Blast Radius: 17.8

Affected Packages