Ecosyste.ms: Advisories

An open API service providing security vulnerability metadata for many open source software ecosystems.

Security Advisories: GSA_kwCzR0hTQS13YzY5LXJoanItaGM5Z84AAtHU

Moment.js vulnerable to Inefficient Regular Expression Complexity

Impact

using string-to-date parsing in moment (more specifically rfc2822 parsing, which is tried by default) has quadratic (N^2) complexity on specific inputs
noticeable slowdown is observed with inputs above 10k characters
users who pass user-provided strings without sanity length checks to moment constructor are vulnerable to (Re)DoS attacks

Patches

The problem is patched in 2.29.4, the patch can be applied to all affected versions with minimal tweaking.

Workarounds

In general, given the proliferation of ReDoS attacks, it makes sense to limit the length of the user input to something sane, like 200 characters or less. I haven't seen legitimate cases of date-time strings longer than that, so all moment users who do pass a user-originating string to constructor are encouraged to apply such a rudimentary filter, that would help with this but also most future ReDoS vulnerabilities.

References

There is an excellent writeup of the issue here: https://github.com/moment/moment/pull/6015#issuecomment-1152961973=

Details

The issue is rooted in the code that removes legacy comments (stuff inside parenthesis) from strings during rfc2822 parsing. moment("(".repeat(500000)) will take a few minutes to process, which is unacceptable.

Permalink: https://github.com/advisories/GHSA-wc69-rhjr-hc9g
JSON: https://advisories.ecosyste.ms/api/v1/advisories/GSA_kwCzR0hTQS13YzY5LXJoanItaGM5Z84AAtHU
Source: GitHub Advisory Database
Origin: Unspecified
Severity: High
Classification: General
Published: almost 2 years ago
Updated: 5 months ago

CVSS Score: 7.5
CVSS vector: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H

Identifiers: GHSA-wc69-rhjr-hc9g, CVE-2022-31129
References:

Repository: https://github.com/moment/moment
Blast Radius: 46.0

Affected Packages

nuget:Moment.js

Dependent packages: 0
Dependent repositories: 0
Downloads: 19,622,102 total
Affected Version Ranges: >= 2.18.0, < 2.29.4
Fixed in: 2.29.4
All affected versions: 2.18.0, 2.18.1, 2.18.2, 2.19.0, 2.19.1, 2.19.2, 2.19.3, 2.19.4, 2.20.0, 2.20.1, 2.21.0, 2.22.0, 2.22.1, 2.22.2, 2.23.0, 2.24.0, 2.25.0, 2.25.1, 2.25.2, 2.26.0, 2.27.0, 2.28.0, 2.29.0, 2.29.1, 2.29.2, 2.29.3
All unaffected versions: 1.2.0, 1.3.0, 1.4.0, 1.5.0, 1.5.1, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 1.7.2, 2.0.0, 2.1.0, 2.2.0, 2.2.1, 2.3.0, 2.3.1, 2.4.0, 2.5.0, 2.5.1, 2.6.0, 2.7.0, 2.8.0, 2.8.1, 2.8.2, 2.8.3, 2.8.4, 2.9.0, 2.10.0, 2.10.1, 2.10.2, 2.10.3, 2.10.5, 2.10.6, 2.11.0, 2.11.1, 2.11.2, 2.12.0, 2.13.0, 2.14.1, 2.14.2, 2.14.3, 2.15.0, 2.15.1, 2.15.2, 2.16.0, 2.17.0, 2.17.1, 2.29.4, 2.30.0, 2.30.1

npm:moment

Dependent packages: 54,055
Dependent repositories: 1,006,179
Downloads: 80,231,810 last month
Affected Version Ranges: >= 2.18.0, < 2.29.4
Fixed in: 2.29.4
All affected versions: 2.18.0, 2.18.1, 2.19.0, 2.19.1, 2.19.2, 2.19.3, 2.19.4, 2.20.0, 2.20.1, 2.21.0, 2.22.0, 2.22.1, 2.22.2, 2.23.0, 2.24.0, 2.25.0, 2.25.1, 2.25.2, 2.25.3, 2.26.0, 2.27.0, 2.28.0, 2.29.0, 2.29.1, 2.29.2, 2.29.3
All unaffected versions: 1.0.0, 1.0.1, 1.1.0, 1.1.1, 1.2.0, 1.3.0, 1.4.0, 1.5.0, 1.5.1, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 1.7.2, 2.0.0, 2.1.0, 2.2.1, 2.3.0, 2.3.1, 2.4.0, 2.5.0, 2.5.1, 2.6.0, 2.7.0, 2.8.1, 2.8.2, 2.8.3, 2.8.4, 2.9.0, 2.10.2, 2.10.3, 2.10.5, 2.10.6, 2.11.0, 2.11.1, 2.11.2, 2.12.0, 2.13.0, 2.14.0, 2.14.1, 2.15.0, 2.15.1, 2.15.2, 2.16.0, 2.17.0, 2.17.1, 2.29.4, 2.30.0, 2.30.1