Ecosyste.ms: Advisories

Security Advisories: GSA_kwCzR0hTQS13aHB4LXEzcnEtdzhqY84AAve6

Hardening of TypedArrays with non-canonical numeric property names in SES

Impact

What kind of vulnerability is it? Who is impacted?

In Hardened JavaScript, programs can harden objects to safely share objects with co-tenant programs without risk of these other programs tampering with their API surface. Hardening does not guarantee that objects are pure or immutable, so a hardened Map, for example is superficially tamper-proof, but any party holding a reference to the object can both read and write its contents. Based on this precedent, and because TypedArray instances cannot be frozen with Object.isFrozen, harden does not freeze TypedArrays and instead makes them non-extensible and makes all non-indexed properties non-writable and non-configurable. This is consistent with the treatment of Map because the indexed properties represent mutable content and non-indexed properties represent the API.

Due to a defect in harden, properties that have names that parse as numbers but are not the same as the canonical representation of those numbers, as in "+0" and "" which are both equivalent to their canonical number "0", remain writable after hardening.

Any program treating one of these properties as part of its API and relying on harden to prevent modifications would be vulnerable to an API pollution attack, affecting only instances shared by mutually suspicious parties.

Unlike a Map, a hardened TypedArray can only have numbers for content. Any program that is sharing hardened TypedArrays between co-tentant programs and relying on harden to only allow these programs to communicate exclusively by changing numbers within the bounds of the TypedArray, may inadvertently have arranged for a mechanism for a pair of third-parties to communicate arbitrary objects on these other properties.

Patches

Has the problem been patched? What versions should users upgrade to?

SES version 0.16.0 patches this issue, causing harden to recognize properties with non-canonical numeric representations and ensuring that these properties are non-configurable.

Workarounds

Is there a way for users to fix or remediate the vulnerability without upgrading?

Users should avoid sharing TypedArrays between co-tenant programs and instead create wrapper objects that produce a read-only view of the underlying data. We allow harden to succeed for TypedArrays because the treatment is in fact consistent with the behavior of collections like Map, but all collections shared between co-tentant programs should probably be attenuated to either read- or write-only facets and probably close over only part of the content of the collection. However, the motivation for allowing TypedArrays to be hardened in practice is to allow certain legacy modules to function under Hardened JavaScript with LavaMoat, since they export TypedArrays, even though they would ideally export read-only facets of these.

References

Are there any links users can visit to find out more?

Not at this time.

For more information

If you have any questions or comments about this advisory:

• Email us at [email protected]

Permalink: https://github.com/advisories/GHSA-whpx-q3rq-w8jc
JSON: https://advisories.ecosyste.ms/api/v1/advisories/GSA_kwCzR0hTQS13aHB4LXEzcnEtdzhqY84AAve6
Source: GitHub Advisory Database
Origin: Unspecified
Severity: Low
Classification: General
Published: over 1 year ago
Updated: over 1 year ago

Identifiers: GHSA-whpx-q3rq-w8jc
References:

• https://github.com/endojs/endo/security/advisories/GHSA-whpx-q3rq-w8jc
• https://github.com/endojs/endo/commit/88cab0be4cf816dc578f2ff441fd9bcda0aa5cf5
• https://github.com/advisories/GHSA-whpx-q3rq-w8jc

Repository: https://github.com/endojs/endo
Blast Radius: 0.0

Affected Packages