Ecosyste.ms: Advisories

Security Advisories: GSA_kwCzR0hTQS14Y2hxLXc1cjMtNHdnM84AA7UJ

vyper performs incorrect topic logging in raw_log

Summary

Incorrect values can be logged when raw_log builtin is called with memory or storage arguments to be used as topics.

A contract search was performed and no vulnerable contracts were found in production. In particular, no uses of raw_log() were found at all in production; it is apparently not a well-known function.

Details

The build_IR function of the RawLog class fails to properly unwrap the variables provided as topics. Consequently, incorrect values are logged as topics.

PoC

x: bytes32

@external
def f():
    self.x = 0x1234567890123456789012345678901234567890123456789012345678901234
    raw_log([self.x], b"") # LOG1(offset:0x60, size:0x00, topic1:0x00)

    y: bytes32 = 0x1234567890123456789012345678901234567890123456789012345678901234
    raw_log([y], b"") # LOG1(offset:0x80, size:0x00, topic1:0x40)

Patches

Fixed in https://github.com/vyperlang/vyper/pull/3977.

Impact

Incorrect values can be logged which may result in unexpected behavior in client-side applications relying on these logs.

Permalink: https://github.com/advisories/GHSA-xchq-w5r3-4wg3
JSON: https://advisories.ecosyste.ms/api/v1/advisories/GSA_kwCzR0hTQS14Y2hxLXc1cjMtNHdnM84AA7UJ
Source: GitHub Advisory Database
Origin: Unspecified
Severity: Moderate
Classification: General
Published: 9 months ago
Updated: 7 months ago

CVSS Score: 5.3
CVSS vector: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:L/A:N

EPSS Percentage: 0.00046
EPSS Percentile: 0.18938

Identifiers: GHSA-xchq-w5r3-4wg3, CVE-2024-32645
References:

• https://github.com/vyperlang/vyper/security/advisories/GHSA-xchq-w5r3-4wg3
• https://nvd.nist.gov/vuln/detail/CVE-2024-32645
• https://github.com/advisories/GHSA-xchq-w5r3-4wg3

Repository: https://github.com/vyperlang/vyper
Blast Radius: 12.6

Affected Packages