Ecosyste.ms: Advisories

Security Advisories: GSA_kwCzR0hTQS1nMnhoLWM0MjYtdjhtZs4AA1rE

Vyper: reversed order of side effects for some operations

Impact

For the following (probably non-exhaustive) list of expressions, the compiler evaluates the arguments from right to left instead of left to right.

- unsafe_add
- unsafe_sub
- unsafe_mul
- unsafe_div
- pow_mod256
- |, &, ^ (bitwise operators)
- bitwise_or (deprecated)
- bitwise_and (deprecated)
- bitwise_xor (deprecated)
- raw_call
- <, >, <=, >=, ==, !=
- in, not in (when lhs and rhs are enums)

This behaviour becomes a problem when the evaluation of one of the arguments produces side effects that other arguments depend on. The following expressions can produce side-effect:

• state modifying external call
• state modifying internal call
• raw_call
• pop() when used on a Dynamic Array stored in the storage
• create_minimal_proxy_to
• create_copy_of
• create_from_blueprint

For example:

f:uint256

@internal
def side_effect() -> uint256:
    self.f = 12
    return 1

@external
def foo() -> uint256:
    return unsafe_add(self.f,self.side_effect()) # returns 13 instead of 1

a:DynArray[uint256, 12]
@external
def bar() -> bool:
    self.a = [1,2,3]
    return len(self.a) == self.a.pop() # return false instead of true

Patches

not yet patched, will address in a future release. tracking in https://github.com/vyperlang/vyper/issues/3604.

Workarounds

When using expressions from the list above, make sure that the arguments of the expression do not produce side effects or, if one does, that no other argument is dependent on those side effects.

References

Are there any links users can visit to find out more?

Permalink: https://github.com/advisories/GHSA-g2xh-c426-v8mf
JSON: https://advisories.ecosyste.ms/api/v1/advisories/GSA_kwCzR0hTQS1nMnhoLWM0MjYtdjhtZs4AA1rE
Source: GitHub Advisory Database
Origin: Unspecified
Severity: Moderate
Classification: General
Published: over 1 year ago
Updated: about 2 months ago

CVSS Score: 5.3
CVSS vector: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:L/A:N

EPSS Percentage: 0.00054
EPSS Percentile: 0.23679

Identifiers: GHSA-g2xh-c426-v8mf, CVE-2023-40015
References:

• https://github.com/vyperlang/vyper/security/advisories/GHSA-g2xh-c426-v8mf
• https://nvd.nist.gov/vuln/detail/CVE-2023-40015
• https://github.com/pypa/advisory-database/tree/main/vulns/vyper/PYSEC-2023-167.yaml
• https://github.com/vyperlang/vyper/issues/3604
• https://github.com/vyperlang/vyper/issues/4019
• https://github.com/vyperlang/vyper/pull/4157
• https://github.com/advisories/GHSA-g2xh-c426-v8mf

Repository: https://github.com/vyperlang/vyper
Blast Radius: 12.6

Affected Packages