An open API service providing security vulnerability metadata for many open source software ecosystems.
MITM based Zip Slip in `ca.uhn.hapi.fhir:org.hl7.fhir.core`
MITM can enable Zip-Slip.
There is no validation that the zip file being unpacked has entries that are not maliciously writing outside of the intended destination directory. https://github.com/hapifhir/org.hl7.fhir.core/blob/8c43e21094af971303131efd081503e5a112db4b/org.hl7.fhir.validation/src/main/java/org/hl7/fhir/validation/Scanner.java#L335-L357
This zip archive is downloaded over HTTP instead of HTTPS, leaving it vulnerable to compromise in-flight. https://github.com/hapifhir/org.hl7.fhir.core/blob/8c43e21094af971303131efd081503e5a112db4b/org.hl7.fhir.validation/src/main/java/org/hl7/fhir/validation/Scanner.java#L136
Note: While these links point to only one implementation, both implementations of
TerminologyCacheManager.java are vulnerable to this as their code seems to be duplicated.
While there is validation in this bit of logic that attempts to validate that the zip file doesn't contain malicious entries that escape the destination directory, the guard is insufficient.
This is because the
Utilities.path(String... path) method does not normalize the path, although it seems to be attempting to do so.
The normalization only occurs if the path element starts with a path traversal payload. As an example, calling
Utilities.path("/base", "/child/../test") will return the string
This guard logic can, thus, be easily bypassed: https://github.com/hapifhir/org.hl7.fhir.core/blob/f58b7acfb5e393cac52cc5bbb170bdb669c2880e/org.hl7.fhir.r5/src/main/java/org/hl7/fhir/r5/terminologies/TerminologyCacheManager.java#L100-L104
Assuming an attacker can control the return value of
ze.getName(), they can supply a value like
Similarly, an attacker can control the contents of the Zip file via a MITM attack as this logic is used with resources not downloaded over HTTPS.https://github.com/advisories/GHSA-jqh6-9574-5x22
Source: GitHub Advisory Database
Published: 12 days ago
Updated: 9 days ago
CVSS Score: 9.1
CVSS vector: CVSS:3.1/AV:N/AC:L/PR:H/UI:N/S:C/C:H/I:H/A:H
Identifiers: GHSA-jqh6-9574-5x22, CVE-2023-24057
Fixed in: 5.6.92