Ecosyste.ms: Advisories

Security Advisories: GSA_kwCzR0hTQS1ycnh2LXE4bTQtd2NoM84AA0_N

.eth registrar controller can shorten the duration of registered names

Description

According to the documentation, controllers are allowed to register new domains and extend the expiry of existing domains, but they cannot change the ownership or reduce the expiration time of existing domains. However, a preliminary analysis suggests that an attacker-controlled controller may be able to reduce the expiration time of existing domains due to an integer overflow in the renew function.

The vulnerability resides in the following GitHub repository: https://github.com/ensdomains/ens-contracts/blob/master/contracts/ethregistrar/BaseRegistrarImplementation.sol#L171

The vulnerable line of code is:

require(
            expiries[id] + duration + GRACE_PERIOD > duration + GRACE_PERIOD
        ); // Prevent future overflow

In this code snippet, the duration variable is user-supplied, making it possible to provide a value that would cause an overflow on both sides of the '>' expression, ultimately rendering the condition true. Specifically, when the duration is set to 2^256 - GRACE_PERIOD, the subsequent line expiries[id] += duration; also experiences an overflow, as expiries[id] is greater than GRACE_PERIOD. This results in the reduction of expiries[id] by GRACE_PERIOD. By repeatedly calling the renew function, an attacker could potentially force the expiration of an ENS record.

You can find the PoC included in the attached document. To execute the test, please use the following command:

forge test -vvv --match-contract RegistrarExploit --fork-url <alchemy_url>

Replace <alchemy_url> with your Alchemy API URL. This command will run the Foundry test file and demonstrate the potential vulnerability.

Impact

If successfully exploited, this vulnerability would enable attackers to force the expiration of any ENS record, ultimately allowing them to claim the affected domains for themselves.

Currently, it would require a malicious DAO to exploit it. Nevertheless, any vulnerability present in the controllers could potentially render this issue exploitable in the future.

An additional concern is the possibility of renewal discounts. Should ENS decide to implement a system that offers unlimited .eth domains for a fixed fee in the future, the vulnerability could become exploitable by any user due to the reduced attack cost.

Patches

A mitigation is being developed.

Workarounds

As long as registration cost remains linear or superlinear based on registration duration, or limited to a reasonable maximum (eg, 1 million years), this vulnerability could only be exploited by a malicious DAO. The interim workaround is thus to take no action.

Permalink: https://github.com/advisories/GHSA-rrxv-q8m4-wch3
JSON: https://advisories.ecosyste.ms/api/v1/advisories/GSA_kwCzR0hTQS1ycnh2LXE4bTQtd2NoM84AA0_N
Source: GitHub Advisory Database
Origin: Unspecified
Severity: Moderate
Classification: General
Published: 9 months ago
Updated: 6 months ago

CVSS Score: 4.9
CVSS vector: CVSS:3.1/AV:N/AC:L/PR:H/UI:N/S:U/C:N/I:H/A:N

Identifiers: GHSA-rrxv-q8m4-wch3, CVE-2023-38698
References:

• https://github.com/ensdomains/ens-contracts/security/advisories/GHSA-rrxv-q8m4-wch3
• https://github.com/ensdomains/ens-contracts/commit/e6b136e979084de3761c125142620304173990ca
• https://github.com/ensdomains/ens-contracts/blob/master/contracts/ethregistrar/BaseRegistrarImplementation.sol#L171
• https://nvd.nist.gov/vuln/detail/CVE-2023-38698
• https://github.com/advisories/GHSA-rrxv-q8m4-wch3

Repository: https://github.com/ensdomains/ens-contracts
Blast Radius: 10.4

Affected Packages