The Deserialize
implementation for VecStorage
did not maintain the invariant that the number of elements must equal nrows * ncols
. Deserialization of specially crafted inputs could allow memory access beyond allocation of the vector.
This flaw was introduced in v0.11.0 (086e6e
) due to the addition of an automatically derived implementation of Deserialize
for MatrixVec
. MatrixVec
was later renamed to VecStorage
in v0.16.13 (0f66403
) and continued to use the automatically derived implementation of Deserialize
.
This flaw was corrected in commit 5bff536
by returning an error during deserialization if the number of elements does not exactly match the expected size.
- https://github.com/dimforge/nalgebra/issues/883
- https://github.com/dimforge/nalgebra/pull/889
- https://github.com/dimforge/nalgebra/commit/a803271fcce75b7c151e92aa099dfa546db4adc5
- https://github.com/dimforge/nalgebra/blob/dev/CHANGELOG.md#0270
- https://rustsec.org/advisories/RUSTSEC-2021-0070.html
- https://github.com/advisories/GHSA-h3mf-4fwp-59c7