Ecosyste.ms: Advisories
An open API service providing security vulnerability metadata for many open source software ecosystems.
Security Advisories: MDE2OlNlY3VyaXR5QWR2aXNvcnlHSFNBLXBjMjItM2c3Ni1nbTZq
Generator Web Application: Local Privilege Escalation Vulnerability via System Temp Directory
Impact
On Unix like systems, the system's temporary directory is shared between all users on that system. A collocated user can observe the process of creating a temporary sub directory in the shared temporary directory and race to complete the creation of the temporary subdirectory.
This vulnerability is local privilege escalation because the contents of the outputFolder
can be appended to by an attacker. As such, code written to this directory, when executed can be attacker controlled.
Java Code
The method File.createTempFile
from the JDK is vulnerable to this local information disclosure vulnerability.
Patches
Fix has been applied to the master branch with:
included in release: 2.4.19
References
- CWE-378: Creation of Temporary File With Insecure Permissions
- CWE-379: Creation of Temporary File in Directory with Insecure Permissions
For more information
If you have any questions or comments about this advisory:
- Email us at [email protected]
Original vulnerability report
Permalink: https://github.com/advisories/GHSA-pc22-3g76-gm6jI'm performing OSS security research under the GitHub Security Lab Bug Bounty program.
I've been using a custom CodeQL query to find local temporary directory vulnerabilities in OSS with three custom CodeQL queries.
- https://github.com/github/codeql/pull/4388/files#diff-71d36c0f2bd0b08e32866f873f1c906cdc17277e0ad327c0c6cd2c882f30de4f
- https://github.com/github/codeql/pull/4388/files#diff-1893a18a8bf43c011d61a7889d0139b998a5a78701a30fe7722eddd4c506aaac
- https://github.com/github/codeql/pull/4473
The code generated by the Swagger Generator contains a local information disclosure vulnerability. The system temporary directory, on unix-like systems is shared between multiple users. Information written to this directory, or directories created under this directory that do not correctly set the posix standard permissions can have these directories read/modified by other users.
This vulnerability exists in the maven plugin.
This vulnerability is distinctly different. This vulnerability is most likely a local privilege escalation vulnerability.
This vulnerability is very similar to this similar vulnerability I disclosed in the Eclipse Jetty project.
https://github.com/eclipse/jetty.project/security/advisories/GHSA-g3wg-6mcf-8jj6
This is due to a race condition between the call to
delete
and the call tomkdirs
.// ensure file will always be unique by appending random digits File outputFolder = File.createTempFile("codegen-", "-tmp"); // Attacker knows the full path of the file that will be generated // delete the file that was created outputFolder.delete(); // Attacker sees file is deleted and begins a race to create their own directory before Swagger Code Generator. // and make a directory of the same name // SECURITY VULNERABILITY: Race Condition! - Attacker beats Swagger Code Generator and now owns this directory outputFolder.mkdirs();
This vulnerability is local privilege escalation because the contents of the
outputFolder
can be appended to by an attacker. As such, code written to this directory, when executed can be attacker controlled.The fix here is to switch to the
Files
API for creating temporary directories. Which does not contain this race condition, and appropriately sets the correct file permissions.
JSON: https://advisories.ecosyste.ms/api/v1/advisories/MDE2OlNlY3VyaXR5QWR2aXNvcnlHSFNBLXBjMjItM2c3Ni1nbTZq
Source: GitHub Advisory Database
Origin: Unspecified
Severity: Low
Classification: General
Published: about 3 years ago
Updated: about 1 year ago
CVSS Score: 9.4
CVSS vector: CVSS:3.1/AV:L/AC:L/PR:N/UI:N/S:C/C:H/I:H/A:H
Identifiers: GHSA-pc22-3g76-gm6j, CVE-2021-21363
References:
- https://github.com/swagger-api/swagger-codegen/security/advisories/GHSA-pc22-3g76-gm6j
- https://nvd.nist.gov/vuln/detail/CVE-2021-21363
- https://github.com/swagger-api/swagger-codegen/commit/987ea7a30b463cc239580d6ad166c707ae942a89
- https://github.com/advisories/GHSA-pc22-3g76-gm6j
Blast Radius: 22.0
Affected Packages
maven:io.swagger:swagger-codegen
Dependent packages: 34Dependent repositories: 218
Downloads:
Affected Version Ranges: < 2.4.19
Fixed in: 2.4.19
All affected versions: 2.1.1, 2.1.2, 2.1.3, 2.1.4, 2.1.5, 2.1.6, 2.2.0, 2.2.1, 2.2.2, 2.2.3, 2.3.0, 2.3.1, 2.4.0, 2.4.1, 2.4.2, 2.4.3, 2.4.4, 2.4.5, 2.4.6, 2.4.7, 2.4.8, 2.4.9, 2.4.10, 2.4.11, 2.4.12, 2.4.13, 2.4.14, 2.4.15, 2.4.16, 2.4.17, 2.4.18
All unaffected versions: 2.4.19, 2.4.20, 2.4.21, 2.4.22, 2.4.23, 2.4.24, 2.4.25, 2.4.26, 2.4.27, 2.4.28, 2.4.29, 2.4.30, 2.4.31, 2.4.32, 2.4.33, 2.4.34, 2.4.35, 2.4.36, 2.4.37, 2.4.38, 2.4.39, 2.4.40, 2.4.41